refactor: revamp to use data access layer #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rakibansary merged 149 commits into master from dev

Mar 26, 2023

Contributor

rakibansary commented Mar 26, 2023

all database operations are done through @topcoder-framework/domain-challenge
the grpc-service domain-challenge writes to both informix and dynamodb
this release deprecates https://github.com/topcoder-platform/legacy-challenge-processor, https://github.com/topcoder-platform/legacy-challenge-migration-script and no longer relies on challenge v4 API and direct
PUT /challenges/:challengeId has been deprecated and currently behaves exactly as PATCH /challenges/:challengeId - this lets us update only the fields that were updated instead of updating the entire challenge update on each API call

rakibansary and others added 30 commits

October 26, 2022 19:58

wip

8135ac8


          wip: test xray

f3c8fda


          wip: more tracing

75ef95b


          wip: dont send trace info to bus

7ac1980


          feat: challenge phase extension

3e0a4f6

* move common phase functionality to a phase helper
* remove post-mortem phase if submission phase is opened
* determine isOpen status based on start and end dates


          fix: incorrect reference

b35ee6f


          fix: actual end date

29ebffc


          fix: actual end time & actual start time

db9bdad


          fix: post-mortem phase

* post-mortem phase should be "scheduled" if submission phase is opened
* because of extension


          Merge branch 'feat/tracing' into feat/phase-extension

932cb27


          feat(tracing): include trace info in payload sent to bus

418b797


          fix: only allow Active, Draft challenges to be extended

33e4bb0


          fix: only allow Active, Draft challenges to be extended

69c0f26


          fix (challenge extension): throw error when challenge phase and/or st…

20c4a1d

…art date modification is not allowed


          fix(challenge update): disallow updating phase/startdate for complete…

78a2587

…d/cancelled challenges


          refactor: format using prettier

7459c60


          feat: handle grpc errors

6aa8869


          feat: use domain object for challenge timeline template

30814fd


          feat: use domain object for lookups

90730cb


          feat: add support for update operation in challenge timeline template

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          fix: challenge timeline template delete response

3d7eb5a


          refactor(domain-challenge): wip timeline template


          refactor(domain-challenge): use dal for challenge type db interactions

73e1dc1


          refactor(domain-challenge): use dal for challenge track, phases, time…

944cfd6

…line templates


          refactor(domain-challenge): update attachment and phase helper to use…

caff461

… dal


          feat: use domain-challenge to create challenge

4f15efb

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          feat: use challenge domain

6591e1f


          chore: lint fixes

8659f02


          refactor(domain-challenge): integrate update/delete with dal for chal…

d945984

…lenges


          refactor(domain-challenge): remove audit logs from challenge service

ae8ef3c

rakibansary and others added 27 commits

March 24, 2023 06:47


          feat: remove attributes that match exactly with saved challenge

5e4b07f

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          refactor: challenge update

e70465e


          fix: allow memberId to be a number

8782f0e

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          fix: getM2MToken reference

e3d6dcd


          Merge pull request #572 from topcoder-platform/fix/getm2mtoken

fa398ce

fix: getM2MToken reference


          fix: winner can not be set for non tasks

669c1b1


          fix: remove hardcoded debug code

243b6e8


          fix: unsetting winners

06578d3

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          fix: phase update object

68a7dfd


          fix: allow private description to be empty

80a4689


          Merge pull request #573 from topcoder-platform/fix/phase-update

99c8645

fix: phase update object


          fix: phases

f0f4dd7


          Merge pull request #574 from topcoder-platform/fix/phase-update

8375f2f

fix: phases


          chore: handle phase update

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          validation updates

b60daa8


          unset legacy.directProjectId as we do not allowe this to change

28d1646


          fix: bump up versions

33247ca

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          fix: prize amount in cents

8ce4e02


          Merge pull request #576 from topcoder-platform/fix/update-validation

1c4dd3a

validation updates


          Merge pull request #578 from topcoder-platform/refactor/challenge-update

ae4c4e7

fix: challenge update


          Merge pull request #579 from topcoder-platform/refactor/domain-challe…

f28085d

…nge-dev

fix: challenge update


          fix: search by legacy id

82b5754

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          Merge pull request #580 from topcoder-platform/refactor/domain-challenge

4b670c1

refactor: revamp to use data access layer


          fix: correctly unset direct project id

22740a3

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          Merge pull request #583 from topcoder-platform/feature/fix-crash

ce1a622

fix: correctly unset direct project id


          ci: deploy to dev

f896dc5

Signed-off-by: Rakib Ansary <rakibansary@gmail.com>


          Merge pull request #584 from topcoder-platform/feature/fix-crash

90514c2

ci: deploy to dev

rakibansary requested a review from eisbilir

March 26, 2023 15:59

eisbilir approved these changes

View reviewed changes

rakibansary merged commit 47bb59f into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet